Listen to YouTube videos, without the distracting visuals.
it should be fine
it's already hard coded in everything.js
@shakeelmohamed
you can create one in the google developer Console for ZAP
@jeanPokou you can use 217347261485-ipt5j5iv2ua0iiq0l43ltrvnt74keqhn.apps.googleusercontent.com for the client ID, however, we'll need to be a bit clever about the callback URL. You can see what I did with https://github.com/shakeelmohamed/youtube-watch-later, it's a bit hairy
I've authorized http & https for localhost or zenplayer.audio for referrer and callback domains
the callback domain is set to the root of the domain, ie: https://zenplayer.audio
Hullo. I've just discovered zen player and would like to help out with any small features/improvements where possible (new to oss).
i found the AV request/idea from under up for grabs label. would it be okay if I gave it a go?
any other issues that would be maybe better suited in terms of "tipping one's toes in" and getting acquainted with the repo/code?
cheers, AJ : )
Hello. I guess that have found a bug when using Chromium, Firefox, Epiphany on Ubuntu 16.04. The app can't get current time of youtube video and almost always starts from the very beginning. I want to have a try and fix it. But the problem is that I can't check the result neither on localhost nor on my sandbox domain because of video lookup request error. Can you please help to find a way to work on the bug?
@shakeelmohamed ok that already shows me as newbie) I've surfed npm documentation a bit and now it works as required. Thanks for response. I'm glad that project is alive and I can try to join the team. So, now I've tested app on Chrome in MacOS and got the same error (Cannot read property 'getCurrentTime' of undefined) which is about starting an audio from the very beginning every time while it works ok when using alias on youtube's original. That's the bug I'm going to work on
@shakeelmohamed thanks for responding. It's really there in the console output. Now I'm ready to make a commit. And as far as it gonna be my first one, I better ask about marking the issue number in commit message. As I've read in "guidelines for contributing" there should be no issues from novices before there first accepted commit. So, what's the best way to do the job?
@shakeelmohamed ok. I've made a pull request. It is not fully about the problem I work on (which is to play on zen from time we left video on youtube). But it just fix the bug when audio always starts from the very beginning. Now it saves the resumeTime correctly. More information is attached to pull request. Keep working on the problem mentioned above.
I've fixed RexExp that worked only with
&t= references for youtube player time. But references from youtube today are ?t= like. So I've fixed RegExp and now it accepts both ? and &. It works okay only with previous fix which is Fix video resume. So I'm gonna make a new pull request that contains both bug fixes since they are connected.
More details attached to pull request
Hello @shakeelmohamed There're three new pull requests waiting for review. As far as I'm newbie I'm greedy for some feed back. I guess you're busy for the time. So just leaving my message here. As I said I'm newbie so I'm not sure about my code for a hundred percent. Need some guidance and feed back to continue work on issues.
Guys, the app is just fantastic! When we add a tool to make a playlist and add user login to save preferences I'd say goodbye to soundcloud :smile: Actually souncloud is cool but the library is really poor. It's not long time passed, but for some time I already use ZAP everyday
I work now on autoplay feature. What if we make a "to be played" and "have played" queues? If "to be played" comes to end the code gets new videos. And now I have a problem with that. What if we make a new query search? If it has video id from
v= option it's ok because we can make an event listener with form submit. And then just place some code in that event handler which updates "to be played" with [ ]. But if it's a query search then it doesn't work. There should be some other event for this case. Can you please help to find out what's that event? As for idea in general I think it'd better to update my pull request first so we can discuss it with code in front of us. But I want to do that after I manage the problem mentioned here.
@avalan4e57 the queues are a different feature, that would allow searching in the background and queueing videos while playing them in order. Autoplay is just a wrapper for YouTube's native autoplay functionality which is totally unpredictable and can't follow the same queueing concept
Hi, I am new to open source. Could someone help me. I followed the contribution guide and setup the system. After making the changes I followed the guide and ran npm test but it is throwing me some errors:
Error: Undefined rule rule-nested-empty-line-before
at module.exports (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/utils/configurationError.js:8:28)
at Object.keys.forEach.ruleName (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/augmentConfig.js:304:13)
at Array.forEach (<anonymous>)
at normalizeAllRuleSettings (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/augmentConfig.js:297:29)
at augmentConfigBasic.then.then.then.augmentedConfig (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/augmentConfig.js:89:14)
npm ERR! code ELIFECYCLE
npm ERR! errno 78
npm ERR! zen-audio-player@1.1.0 stylelint:css: `stylelint css/*.css`
npm ERR! Exit status 78
npm ERR!
npm ERR! Failed at the zen-audio-player@1.1.0 stylelint:css script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.I am getting the above error for
- rule-nested-empty-line-before
- rule-no-duplicate-properties :true
- number-zero-length-no-unit: true
- rule-no-shorthand-property-overrides: true
- "rule-trailing-semicolon": "always"
- "selector-no-universal": true
- "selector-root-no-composition": true,
I checked online on the Rules section of stylint.io .. I couldn't find any of the mentioned rules.
I deleted these rules from the file and ran it again and I stumbled upon this error
'Invalid Option: Invalid option value "true" for rule "color-named"'
According to documentation true is not an option.
I removed that line and ran it again, I found one more error
/Users/chandanpurbia/open_source/zen-audio-player.github.io/js/everything.js
136:9 warning Unexpected console statement no-console
320:13 warning Unexpected console statement no-console
385:5 warning Unexpected console statement no-console
493:30 error Unnecessary escape character: \: no-useless-escape
493:48 error Unnecessary escape character: \. no-useless-escape
493:77 error Unnecessary escape character: \. no-useless-escape
510:37 error Unnecessary escape character: \: no-useless-escape
510:52 error Unnecessary escape character: \: no-useless-escapeLine number 493 and 510 contains regex and are correct according to documentation but I am still getting this error, so I changed the severity of no-useless-escape from error to warning.
and now there are no errors but the process is not ending, it is stuck.
Please help me.
Thankyou :)
