Hullo. I've just discovered zen player and would like to help out with any small features/improvements where possible (new to oss).
i found the AV request/idea from under
up for grabs label. would it be okay if I gave it a go?
any other issues that would be maybe better suited in terms of "tipping one's toes in" and getting acquainted with the repo/code?
cheers, AJ : )
&t=references for youtube player time. But references from youtube today are
?t=like. So I've fixed RegExp and now it accepts both
&. It works okay only with previous fix which is
Fix video resume. So I'm gonna make a new pull request that contains both bug fixes since they are connected.
v=option it's ok because we can make an event listener with form submit. And then just place some code in that event handler which updates "to be played" with
[ ]. But if it's a query search then it doesn't work. There should be some other event for this case. Can you please help to find out what's that event? As for idea in general I think it'd better to update my pull request first so we can discuss it with code in front of us. But I want to do that after I manage the problem mentioned here.
Hi, I am new to open source. Could someone help me. I followed the contribution guide and setup the system. After making the changes I followed the guide and ran
npm test but it is throwing me some errors:
Error: Undefined rule rule-nested-empty-line-before at module.exports (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/utils/configurationError.js:8:28) at Object.keys.forEach.ruleName (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/augmentConfig.js:304:13) at Array.forEach (<anonymous>) at normalizeAllRuleSettings (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/augmentConfig.js:297:29) at augmentConfigBasic.then.then.then.augmentedConfig (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/augmentConfig.js:89:14) npm ERR! code ELIFECYCLE npm ERR! errno 78 npm ERR! email@example.com stylelint:css: `stylelint css/*.css` npm ERR! Exit status 78 npm ERR! npm ERR! Failed at the firstname.lastname@example.org stylelint:css script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
I am getting the above error for
I checked online on the Rules section of
stylint.io .. I couldn't find any of the mentioned rules.
I deleted these rules from the file and ran it again and I stumbled upon this error
'Invalid Option: Invalid option value "true" for rule "color-named"'
According to documentation
true is not an option.
I removed that line and ran it again, I found one more error
/Users/chandanpurbia/open_source/zen-audio-player.github.io/js/everything.js 136:9 warning Unexpected console statement no-console 320:13 warning Unexpected console statement no-console 385:5 warning Unexpected console statement no-console 493:30 error Unnecessary escape character: \: no-useless-escape 493:48 error Unnecessary escape character: \. no-useless-escape 493:77 error Unnecessary escape character: \. no-useless-escape 510:37 error Unnecessary escape character: \: no-useless-escape 510:52 error Unnecessary escape character: \: no-useless-escape
Line number 493 and 510 contains regex and are correct according to documentation but I am still getting this error, so I changed the severity of
no-useless-escape from error to warning.
and now there are no errors but the process is not ending, it is stuck.
Please help me.