Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
jean POKOU
@jeanPokou
@shakeelmohamed done!
Shakeel Mohamed
@shakeelmohamed
@jeanPokou thanks I'll clean it up and merge
jean POKOU
@jeanPokou
@shakeelmohamed we could use Google API client libraries to get auth from user and get his watch later and more
jean POKOU
@jeanPokou
@shakeelmohamed do you have a google client APi for ZAP
Shakeel Mohamed
@shakeelmohamed
@jeanPokou we might be able to use the YouTube API key let me check
it should be fine
it's already hard coded in everything.js
jean POKOU
@jeanPokou
but we need a client Id for auth2
@shakeelmohamed
you can create one in the google developer Console for ZAP
Shakeel Mohamed
@shakeelmohamed
got it. I'll let you know when it's ready @jeanPokou
jean POKOU
@jeanPokou
ok @shakeelmohamed
Shakeel Mohamed
@shakeelmohamed
@jeanPokou you can use 217347261485-ipt5j5iv2ua0iiq0l43ltrvnt74keqhn.apps.googleusercontent.com for the client ID, however, we'll need to be a bit clever about the callback URL. You can see what I did with https://github.com/shakeelmohamed/youtube-watch-later, it's a bit hairy
I've authorized http & https for localhost or zenplayer.audio for referrer and callback domains
the callback domain is set to the root of the domain, ie: https://zenplayer.audio
Jacob Biros
@birosjh
Hello, is this project still ongoing? I'm just now trying to get my foot in the door with OSS, and implemented a simple function that gets a list of related videos (the Suggested Video list).
Shakeel Mohamed
@shakeelmohamed
Hi @birosjh, I haven't been doing any development lately - but I'm happy to review your changes in a PR
andreas
@andreasvirkus

Hullo. I've just discovered zen player and would like to help out with any small features/improvements where possible (new to oss).
i found the AV request/idea from under up for grabs label. would it be okay if I gave it a go?

any other issues that would be maybe better suited in terms of "tipping one's toes in" and getting acquainted with the repo/code?

cheers, AJ : )

Shakeel Mohamed
@shakeelmohamed
@andreasvirkus go for it! Just leave a comment on any issues you start working on
Igor Chernega
@avalan4e57
Hello. I guess that have found a bug when using Chromium, Firefox, Epiphany on Ubuntu 16.04. The app can't get current time of youtube video and almost always starts from the very beginning. I want to have a try and fix it. But the problem is that I can't check the result neither on localhost nor on my sandbox domain because of video lookup request error. Can you please help to find a way to work on the bug?
Shakeel Mohamed
@shakeelmohamed
@avalan4e57 how are you starting the website locally? It should be fine with "npm start"
Igor Chernega
@avalan4e57
@shakeelmohamed ok that already shows me as newbie) I've surfed npm documentation a bit and now it works as required. Thanks for response. I'm glad that project is alive and I can try to join the team. So, now I've tested app on Chrome in MacOS and got the same error (Cannot read property 'getCurrentTime' of undefined) which is about starting an audio from the very beginning every time while it works ok when using alias on youtube's original. That's the bug I'm going to work on
Shakeel Mohamed
@shakeelmohamed
@avalan4e57 sounds good, thanks for the initiative!
Igor Chernega
@avalan4e57
@shakeelmohamed I've made two similar small changes by edding this line of code if (videoDuration === 0) return to "playing" and "timeupdate" eventListeners. Got an eslint js/*.js error when running tests. Can you please tell what's the problem with that?
Shakeel Mohamed
@shakeelmohamed
@avalan4e57 eslint is our code quality tool. Read the console output and it will tell you what you need to fix
Igor Chernega
@avalan4e57
@shakeelmohamed thanks for responding. It's really there in the console output. Now I'm ready to make a commit. And as far as it gonna be my first one, I better ask about marking the issue number in commit message. As I've read in "guidelines for contributing" there should be no issues from novices before there first accepted commit. So, what's the best way to do the job?
Shakeel Mohamed
@shakeelmohamed
@avalan4e57 don't worry about it too much, make a pull request and I'll review it
Igor Chernega
@avalan4e57
@shakeelmohamed ok. I've made a pull request. It is not fully about the problem I work on (which is to play on zen from time we left video on youtube). But it just fix the bug when audio always starts from the very beginning. Now it saves the resumeTime correctly. More information is attached to pull request. Keep working on the problem mentioned above.
Igor Chernega
@avalan4e57
I've fixed RexExp that worked only with &t= references for youtube player time. But references from youtube today are ?t= like. So I've fixed RegExp and now it accepts both ? and &. It works okay only with previous fix which is Fix video resume. So I'm gonna make a new pull request that contains both bug fixes since they are connected.
Igor Chernega
@avalan4e57
@shakeelmohamed hello. It was nice of you to add me to organization. Hope that will turn best for us. As for previously accepted commits, I've found some new bugs with video resume. And have made a new pull request with fixes.
More details attached to pull request
Shakeel Mohamed
@shakeelmohamed
Thanks @avalan4e57 I'll take a look soon 👍
Igor Chernega
@avalan4e57
Hello @shakeelmohamed There're three new pull requests waiting for review. As far as I'm newbie I'm greedy for some feed back. I guess you're busy for the time. So just leaving my message here. As I said I'm newbie so I'm not sure about my code for a hundred percent. Need some guidance and feed back to continue work on issues.
Igor Chernega
@avalan4e57
Guys, the app is just fantastic! When we add a tool to make a playlist and add user login to save preferences I'd say goodbye to soundcloud :smile: Actually souncloud is cool but the library is really poor. It's not long time passed, but for some time I already use ZAP everyday
Shakeel Mohamed
@shakeelmohamed
@avalan4e57 that's awesome to hear!! Thanks for your support
Igor Chernega
@avalan4e57
I work now on autoplay feature. What if we make a "to be played" and "have played" queues? If "to be played" comes to end the code gets new videos. And now I have a problem with that. What if we make a new query search? If it has video id from v= option it's ok because we can make an event listener with form submit. And then just place some code in that event handler which updates "to be played" with [ ]. But if it's a query search then it doesn't work. There should be some other event for this case. Can you please help to find out what's that event? As for idea in general I think it'd better to update my pull request first so we can discuss it with code in front of us. But I want to do that after I manage the problem mentioned here.
Shakeel Mohamed
@shakeelmohamed
@avalan4e57 the queues are a different feature, that would allow searching in the background and queueing videos while playing them in order. Autoplay is just a wrapper for YouTube's native autoplay functionality which is totally unpredictable and can't follow the same queueing concept
Igor Chernega
@avalan4e57
Youtube gives us 5 ides on the request. Do you think that we should peek the first one and ignore the others and then run that procedure again everytime with next video?
Shakeel Mohamed
@shakeelmohamed
@avalan4e57 I'd guess YouTube either does that, or plays all 5 first. I never use that feature so I'm not sure. If you can figure out how YouTube does it and do the same thing
Chandan Purbia
@chandan1794

Hi, I am new to open source. Could someone help me. I followed the contribution guide and setup the system. After making the changes I followed the guide and ran npm test but it is throwing me some errors:

Error: Undefined rule rule-nested-empty-line-before
    at module.exports (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/utils/configurationError.js:8:28)
    at Object.keys.forEach.ruleName (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/augmentConfig.js:304:13)
    at Array.forEach (<anonymous>)
    at normalizeAllRuleSettings (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/augmentConfig.js:297:29)
    at augmentConfigBasic.then.then.then.augmentedConfig (/Users/chandanpurbia/open_source/zen-audio-player.github.io/node_modules/stylelint/lib/augmentConfig.js:89:14)
npm ERR! code ELIFECYCLE
npm ERR! errno 78
npm ERR! zen-audio-player@1.1.0 stylelint:css: `stylelint css/*.css`
npm ERR! Exit status 78
npm ERR!
npm ERR! Failed at the zen-audio-player@1.1.0 stylelint:css script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

I am getting the above error for

  1. rule-nested-empty-line-before
  2. rule-no-duplicate-properties :true
  3. number-zero-length-no-unit: true
  4. rule-no-shorthand-property-overrides: true
  5. "rule-trailing-semicolon": "always"
  6. "selector-no-universal": true
  7. "selector-root-no-composition": true,

I checked online on the Rules section of stylint.io .. I couldn't find any of the mentioned rules.
I deleted these rules from the file and ran it again and I stumbled upon this error
'Invalid Option: Invalid option value "true" for rule "color-named"'
According to documentation true is not an option.

I removed that line and ran it again, I found one more error

/Users/chandanpurbia/open_source/zen-audio-player.github.io/js/everything.js
  136:9   warning  Unexpected console statement      no-console
  320:13  warning  Unexpected console statement      no-console
  385:5   warning  Unexpected console statement      no-console
  493:30  error    Unnecessary escape character: \:  no-useless-escape
  493:48  error    Unnecessary escape character: \.  no-useless-escape
  493:77  error    Unnecessary escape character: \.  no-useless-escape
  510:37  error    Unnecessary escape character: \:  no-useless-escape
  510:52  error    Unnecessary escape character: \:  no-useless-escape

Line number 493 and 510 contains regex and are correct according to documentation but I am still getting this error, so I changed the severity of no-useless-escape from error to warning.

and now there are no errors but the process is not ending, it is stuck.

Please help me.
Thankyou :)

Shakeel Mohamed
@shakeelmohamed
@chandan1794 I've sent you a DM :smile:
MisterAwesome23
@MisterAwesome23
Hello
Shakeel Mohamed
@shakeelmohamed
@MisterAwesome23 hey there! I’m traveling for the next week just FYI
MisterAwesome23
@MisterAwesome23
No worries. Thank you for informing. I have made a pull request which you might want to check out in free time. Thank you 👍
Shakeel Mohamed
@shakeelmohamed
@MisterAwesome23 sure thing, I’ll be back on GitHub in January. Taking some time away to relax 😄 I’ll definitely take a look when I’m back
MisterAwesome23
@MisterAwesome23
Absolutely. Have fun :))
Ivan
@IvanKram
Hey! I was wondering if anybody was working on adapting to iOS browsers. As I see there is no support currently. I would do it if nobody is currently
Shakeel Mohamed
@shakeelmohamed
@IvanKram not sure on the feasibility of this given the aggressive YouTube API which goes full screen. If you find some new information please let us know!
Ivan
@IvanKram
@shakeelmohamed Sure, I will look into the possibility of doing that anyway. But thank you for the red flag :)
Shakeel Mohamed
@shakeelmohamed
Sounds good