Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Lalit Maganti
    @tilal6991
    The idea of wrapping properties feels too much like android databinding.
    Which I really did not like doing.
    I moved to anvil specifically to get away from that.
    And at that point you might as well us android databinding.
    *use
    Sindre Tellevik
    @graknol
    hmm true :/
    Serge Zaitsev
    @zserge
    http://blog.jetbrains.com/kotlin/2016/05/gradle-meets-kotlin/ - I'm not sure if this means that DSL generator can now be rewritten in Kotlin, but that would be a nice improvement
    Sindre Tellevik
    @graknol
    omg!
    btw, I saw that anko generated the DSL from the local android.jar, does Anvil do that too, or does it just use a precompiled one?
    Serge Zaitsev
    @zserge
    Well, yes and no. Anvil generates DSL from android.jar in the local ANDROID_HOME SDK path, but the generated DSL is also stored under version control and included to the published JARs.
    Sindre Tellevik
    @graknol
    ok, I guess it doesn't make a whole lot of difference anyways
    Sindre Tellevik
    @graknol
    I know this is not Anvil related, but damn these new reference pages! https://developer.android.com/reference/android/webkit/WebView.html
    Sindre Tellevik
    @graknol
    @tilal6991 I did it 
    linearLayout {
    button {
        text("EAT SHIT!")
    }.lparams {
        width = dip(320)
        height = dip(160)
        gravity = 1
    }
}
    Lalit Maganti
    @tilal6991
    Nice!
    Sindre Tellevik
    @graknol
    best of all
    no generics!
    I'll push it later today, when I've modified all the libraries
    Sindre Tellevik
    @graknol
    done https://jitpack.io/#graknol/AnvilKotlin/0.4.0
    Lalit Maganti
    @tilal6991
    @graknol Excellent
    Only thing I can see is that the DSL result stub is created a lot
    Can we not make that a singleton?
    Sindre Tellevik
    @graknol
    no, because it has to contain a reference to the currentView after the currentView is gone. if that made sense
    Lalit Maganti
    @tilal6991
    Hmmmmm right.
    Sindre Tellevik
    @graknol
    otherwise we could try to somehow store a stack of views
    Lalit Maganti
    @tilal6991
    A bit frustrating that that's the case but I understand.
    Sindre Tellevik
    @graknol
    it's because of anvil's design :/
    but an incredible improvent nontheless!
    Lalit Maganti
    @tilal6991
    Yes definitely.
    Lalit Maganti
    @tilal6991
    Ouch without some sort of editor plugin, constraintlayout will remain XML only
    Will be very difficult to do with Anvil
    https://github.com/googlecodelabs/constraint-layout/blob/master/constraint-layout-start/app/src/main/res/layout/activity_main_done.xml
    Just look at the size of these files
    Sindre Tellevik
    @graknol
    holy
    Lalit Maganti
    @tilal6991
    I just realised - Google are really pushing styles/themes and it's actually not great that Anvil does not support them
    @graknol @zserge ^
    Sindre Tellevik
    @graknol
    yup
    I noticed that when exploring appcompat
    what's worse is that it has to be applied before creating ANY views (ofc), which means it has to be set before calling super. onCreate()
    which means they have to be static
    which probably means that we have to rely on style xml files
    Sindre Tellevik
    @graknol
    @zserge @tilal6991 I just saw the new layout editor, this is baad news for DSL libraries (not like there's any competition)
    it's sweet though
    Lalit Maganti
    @tilal6991
    Having seen https://www.youtube.com/watch?v=csaXml4xtN8 I think that Anvil would do much better to just use the xml function as the main entry point
    For me personally the new XML editing tools I'm convinced to switch back
    Especially ConstraintLayout
    Sindre Tellevik
    @graknol
    me too
    truth is, not that many state changes happen that often
    which anvil was built for
    so there's normally no downside using the new tools